Skip to content

add split_fastq#61

Merged
maxulysse merged 7 commits intonf-core:devfrom
maxulysse:splitFastq
Dec 2, 2019
Merged

add split_fastq#61
maxulysse merged 7 commits intonf-core:devfrom
maxulysse:splitFastq

Conversation

@maxulysse
Copy link
Copy Markdown
Member

  • new split_fastq params

Many thanks to contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse self-assigned this Nov 5, 2019
Comment thread scripts/run_tests.sh
Comment thread scripts/run_tests.sh
@maxulysse
Copy link
Copy Markdown
Member Author

Need docs

@maxulysse maxulysse added enhancement New feature or request and removed work in progress labels Nov 29, 2019
@maxulysse maxulysse requested a review from a team November 29, 2019 10:09
Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that I didn't find anything to complain about :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants