Skip to content

TMB#616

Open
FriederikeHanssen wants to merge 18 commits intonf-core:devfrom
FriederikeHanssen:tmb_curie
Open

TMB#616
FriederikeHanssen wants to merge 18 commits intonf-core:devfrom
FriederikeHanssen:tmb_curie

Conversation

@FriederikeHanssen
Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen commented Jul 4, 2022 •
edited
Loading

#495

Coming up with a POC for the tmb support:

Idea is to keep all relevant config files for the tmb tool in our own assests folder (or any other that we can control for now). Otherwise we are dependent that all of the tools that we would like to support will get added & released upstream. (Over time of course we could contribute them).

For all vcf files the variantcaller & annotation tool needs to be tracked in the meta map. We are already doing this for the variantcallers anyways. So this should be a small and easy change.

Last but not least the respective file can be retrieved with a groovy function for the proper combination.

Now of course we need to start generating all the db and var config files.

I am not sure yet how we could possibly handle users overwritting the config file. From where I stand at the moment we would need a parameter with which you can pass multiple files with a key...

@nservant
Copy link
Copy Markdown

nservant commented Jul 20, 2022

Hi @FriederikeHanssen,
I had a look at your code ! that's great.
For information, there is a typo in the tmb module

        --dbConfig ${dbConfig} \

should be

        --dbConfig ${dbconfig} \

with small 'c'

@apeltzer apeltzer added this to the 3.1 milestone Jul 21, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 3, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 44d56a1

+| ✅ 151 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-11-10 23:19:32

@FriederikeHanssen
Copy link
Copy Markdown
Contributor Author

FriederikeHanssen commented Aug 11, 2022 •
edited
Loading

  • Update module in nf-core/modules
  • vep.yml
  • strelka.yml
  • freebayes.yml
  • Clear up effGenomeSize computation
  • Update how we handle intervals when running annotation
  • input starting from tmb directly also needs tbi, but for annotation this would cause issues with channels....
  • need to propagate all tbis up from variantcalling
  • allow input configs?

@FriederikeHanssen
Copy link
Copy Markdown
Contributor Author

FriederikeHanssen commented Nov 10, 2022 •
edited
Loading

Ok this is starting to take shape. A couple of things that I could use help with:

  1. generating the yml files for VEP, Strelka, & Freebayes.
  2. Which parameters do we need?

1 & 2 maybe @apeltzer @tomgutman have any advice?

  1. @maxulysse this is starting to shape into a new subworkflow after annotation, how do we want to call this step? post-processing is not descriptive. We would probably need to track back metadata that we dropped. Here for example we only want to run this tool on somatic data

@apeltzer
Copy link
Copy Markdown
Member

apeltzer commented Nov 14, 2022

For 3.) --> maybe somehing like "downstream-metrics"? :-)

@maxulysse
Copy link
Copy Markdown
Member

maxulysse commented Nov 14, 2022

For 3.) --> maybe somehing like "downstream-metrics"? :-)

I'd even go just for downstream

@tomgutman
Copy link
Copy Markdown

tomgutman commented Nov 16, 2022

Hello,

unfortunately I don't have any expertise in VEP, strelka and freebayes. So I can't really help on that. =/
Sorry

@maxulysse maxulysse modified the milestones: 3.1, 3.2 Nov 23, 2022
@apeltzer
Copy link
Copy Markdown
Member

apeltzer commented Feb 2, 2023

I'll prio the generation of the YAML files soon and will either find some time myself or have someone look into it.

@maxulysse maxulysse removed this from the 3.2 milestone Jun 22, 2023
@maxulysse maxulysse added this to the 3.3 milestone Jun 22, 2023
@maxulysse maxulysse modified the milestones: 3.3, 3.4, 3.5 Feb 8, 2024
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
@bounlu bounlu marked this pull request as ready for review September 2, 2024 05:31
@bounlu bounlu requested a review from maxulysse as a code owner September 2, 2024 05:31
@bounlu bounlu mentioned this pull request Nov 20, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Sarek Board
Status: Not planned for this release

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@FriederikeHanssen @nservant @apeltzer @maxulysse @tomgutman
⚡