Skip to content

add test full config to aws s3#617

Merged
ggabernet merged 3 commits intonf-core:devfrom
ggabernet:dev
Jul 5, 2022
Merged

add test full config to aws s3#617
ggabernet merged 3 commits intonf-core:devfrom
ggabernet:dev

Conversation

@ggabernet
Copy link
Copy Markdown
Member

Sorry, I didn't remember that the test full metadata sheet should actually be added to s3 or it can't be staged when running tests

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ggabernet ggabernet requested a review from maxulysse as a code owner July 4, 2022 17:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 742405e

+| ✅ 145 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_description - No description provided in schema for parameter: ascat_chromosomes

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-04 17:58:25

@ggabernet ggabernet merged commit 261785b into nf-core:dev Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants