Skip to content

add cnvkit index#661

Merged
FriederikeHanssen merged 4 commits intonf-core:devfrom
FriederikeHanssen:index_svg
Jul 20, 2022
Merged

add cnvkit index#661
FriederikeHanssen merged 4 commits intonf-core:devfrom
FriederikeHanssen:index_svg

Conversation

@FriederikeHanssen
Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen commented Jul 19, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 19, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2fd6afd

+| ✅ 146 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_description - No description provided in schema for parameter: ascat_ploidy

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-20 08:54:59

SusiJo
SusiJo approved these changes Jul 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SusiJo SusiJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@SusiJo
Copy link
Copy Markdown
Contributor

SusiJo commented Jul 20, 2022

Just one question: The text elements are missing in the svg. Do you want it to stay like that or convert the elements to text? I know it was a pain to do that with the fonts 😬

@FriederikeHanssen
Copy link
Copy Markdown
Contributor Author

FriederikeHanssen commented Jul 20, 2022

yes I'll update those

@maxulysse
Copy link
Copy Markdown
Member

maxulysse commented Jul 20, 2022

Fixed the CHANGELOG conflict

@FriederikeHanssen FriederikeHanssen merged commit 93a4925 into nf-core:dev Jul 20, 2022
@FriederikeHanssen FriederikeHanssen deleted the index_svg branch July 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

@apeltzer apeltzer apeltzer approved these changes

@SusiJo SusiJo SusiJo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FriederikeHanssen @SusiJo @maxulysse @apeltzer
⚡