Skip to content

tiny memory update + split fastq default value as discussed on slack#674

Merged
FriederikeHanssen merged 5 commits intonf-core:devfrom
FriederikeHanssen:small_ressource
Jul 21, 2022
Merged

tiny memory update + split fastq default value as discussed on slack#674
FriederikeHanssen merged 5 commits intonf-core:devfrom
FriederikeHanssen:small_ressource

Conversation

@FriederikeHanssen
Copy link
Copy Markdown
Contributor

@FriederikeHanssen FriederikeHanssen commented Jul 20, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 20, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6c7f310

+| ✅ 145 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-21 06:54:20

SusiJo
SusiJo reviewed Jul 21, 2022
View reviewed changes
Comment thread nextflow_schema.json Outdated
@@ -258,10 +258,11 @@
},
"ascat_ploidy": {
"type": "string",
Copy link
Copy Markdown
Contributor

@SusiJo SusiJo Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a string?

Suggested change
"type": "string",
"type": "number",

asp8200
asp8200 reviewed Jul 21, 2022
View reviewed changes
Comment thread nextflow_schema.json Outdated
"ascat_ploidy": {
"type": "string",
"default": null,
"default": "None",
Copy link
Copy Markdown
Contributor

@asp8200 asp8200 Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about the change from null to "None"?

@FriederikeHanssen
Copy link
Copy Markdown
Contributor Author

FriederikeHanssen commented Jul 21, 2022

good catch @asp8200 and @SusiJo , didn't pay enough attention when using schema build. updated now

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review July 21, 2022 06:47
@FriederikeHanssen FriederikeHanssen merged commit 25d91c2 into nf-core:dev Jul 21, 2022
@FriederikeHanssen FriederikeHanssen deleted the small_ressource branch July 10, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asp8200 asp8200 asp8200 left review comments

@SusiJo SusiJo SusiJo left review comments

@maxulysse maxulysse maxulysse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FriederikeHanssen @maxulysse @asp8200 @SusiJo
⚡