Skip to content

Remove label memory_max from BaseRecalibrator process#73

Merged
maxulysse merged 1 commit intonf-core:devfrom
maxulysse:MemoryBaseRecalibrator
Dec 4, 2019
Merged

Remove label memory_max from BaseRecalibrator process#73
maxulysse merged 1 commit intonf-core:devfrom
maxulysse:MemoryBaseRecalibrator

Conversation

@maxulysse
Copy link
Copy Markdown
Member

@maxulysse maxulysse commented Dec 3, 2019

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse requested a review from a team December 3, 2019 19:40
@maxulysse maxulysse self-assigned this Dec 3, 2019
@maxulysse maxulysse changed the title remove label memory_max from BaseRecalibrator process to fix #72 Remove label memory_max from BaseRecalibrator process Dec 3, 2019
@maxulysse maxulysse requested a review from szilvajuhos December 3, 2019 19:45
Copy link
Copy Markdown
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tack, will re-test the whole ICGC once we have enough disk space left (next week maybe)

Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants