Add Patch to enable PRs coming from patch branch#392
Merged
Conversation
Member
Author
|
Okay, tests look like they pass 🎉 x-ref nf-core/hlatyping#66 which was used to test this properly. These tests will pass on all pipelines once we have a new tools release 👍 |
sven1103
approved these changes
Sep 24, 2019
Member
sven1103
left a comment
There was a problem hiding this comment.
Awesome Alex, thanks for getting this on the road!
Member
|
Nice! Would be good to update other travis files too.. eg. the mainly the one for |
Member
Author
|
Ok, will do that asap :-) |
Member
Author
|
Added :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After changing / testing this on
hlatyping, I figured that we need to change this in linting and the template too:https://travis-ci.com/apeltzer/hlatyping/jobs/238549269
PR checklist
docsis updatedCHANGELOG.mdis updatedREADME.mdis updated