Skip to content

Schema validate max resources#855

Merged
drpatelh merged 2 commits intonf-core:devfrom
ewels:schema-validate-max-resources
Feb 17, 2021
Merged

Schema validate max resources#855
drpatelh merged 2 commits intonf-core:devfrom
ewels:schema-validate-max-resources

Conversation

@ewels
Copy link
Copy Markdown
Member

@ewels ewels commented Feb 17, 2021

  • Remove --name from the schema since we removed this core nextflow option from nextflow.config in parameter validation for dev branch #852 (throws a linting warning instead of fail, so wasn't caught by the CI)
  • Added pattern regexes for validation of --max_memory and --max_time
    • Patterns are fairly strict - must now be in the format 123.GB or 456.h
    • Used the prefixes listed on the nextflow docs, neither now allowed without any prefix (e.g.789)
    • --max_cpus is already set as an int so fully validated already

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from drpatelh February 17, 2021 10:42
Copy link
Copy Markdown
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooohooooo!

@drpatelh drpatelh merged commit 1d3c630 into nf-core:dev Feb 17, 2021
@ewels ewels mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants