add cache metrics for NGINX plus#540
Merged
shaun-nx merged 1 commit intonginx:mainfrom Nov 13, 2023
sheharyaar:sheharyaar/issue522
Merged
add cache metrics for NGINX plus#540shaun-nx merged 1 commit intonginx:mainfrom sheharyaar:sheharyaar/issue522
shaun-nx merged 1 commit intonginx:mainfrom
sheharyaar:sheharyaar/issue522
Conversation
shaun-nx
approved these changes
Nov 10, 2023
jjngx
approved these changes
Nov 13, 2023
Contributor
Author
|
The lint check has failed, do I need to perform |
Contributor
Yes, please do run |
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
Contributor
Author
|
Done, fixed lint issues and rebased |
|
Hi @sheharyaar, thanks for contributing to this project! We can merge this PR as soon as the lint errors are fixed. I get these two errors when running For the first error, just run For the 2nd error, it seems like the |
|
@sheharyaar ignore my last command, I was late to the trigger 😆 |
|
Thank you @sheharyaar ! 🎉 |
Contributor
Author
|
Gald to contribute, welcome ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #522 and exposes cache metrics from NGINX Plus API.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
guide