Skip to content

feat: 🎸 add support for v8.2.x, v9.1.x, v10.2.x#2

Merged
NachoVazquez merged 5 commits into
mainfrom
add-more-angular-minor-versions
Oct 24, 2020
Merged

feat: 🎸 add support for v8.2.x, v9.1.x, v10.2.x#2
NachoVazquez merged 5 commits into
mainfrom
add-more-angular-minor-versions

Conversation

@NachoVazquez

@NachoVazquez NachoVazquez commented Oct 22, 2020

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x ] The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • [ x ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Missing support for some minor version of Angular

Issue Number: 1

What is the new behavior?

Adds supports for version 8.2.x, 9.1.x, 10.2.x of Angular.

Does this PR introduce a breaking change?

[ ] Yes
[ x ] No

Other information

Solves issues: #1

@NachoVazquez NachoVazquez requested a review from LayZeeDK October 22, 2020 20:15
Comment thread src/angular-versions.ts Outdated
Comment thread src/angular-versions.ts Outdated
Comment thread README.md Outdated
@LayZeeDK LayZeeDK changed the title feat: 🎸 add support for v8.2.0 v8.3.0 v9.1.0 feat: 🎸 add support for v8.2.0, v9.1.0 Oct 23, 2020
@LayZeeDK LayZeeDK changed the title feat: 🎸 add support for v8.2.0, v9.1.0 feat: 🎸 add support for v8.2.x, v9.1.x, v10.2.x Oct 23, 2020
LayZeeDK and others added 3 commits October 23, 2020 10:26
Co-authored-by: Lars Gyrup Brink Nielsen <layzee.dk@gmail.com>
@NachoVazquez NachoVazquez requested a review from LayZeeDK October 23, 2020 15:57
LayZeeDK
LayZeeDK previously approved these changes Oct 23, 2020
@LayZeeDK

Copy link
Copy Markdown
Member

How do we bump the version number?

@NachoVazquez

NachoVazquez commented Oct 24, 2020

Copy link
Copy Markdown
Contributor Author

How do we bump the version number?

yarn release

One important thing to notice is that before a release is ready we have to build the actions and commit the dist files. I know it sounds weird but it is the way it is done because Github uses those files directly from the repo to deploy the action.

yarn build
yarn package

This can be useful

https://github.com/actions/toolkit/blob/master/docs/action-versioning.md
https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-javascript-action

@NachoVazquez NachoVazquez merged commit 03ccbbd into main Oct 24, 2020
@NachoVazquez NachoVazquez deleted the add-more-angular-minor-versions branch October 24, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants