Skip to content

feat: support Angular Components#31

Merged
LayZeeDK merged 11 commits into
mainfrom
feat/support-angular-material
May 28, 2021
Merged

feat: support Angular Components#31
LayZeeDK merged 11 commits into
mainfrom
feat/support-angular-material

Conversation

@LayZeeDK

@LayZeeDK LayZeeDK commented May 25, 2021

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The latest artifacts are committed (run yarn build)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  1. The Angular Components packages are not managed.
  2. Outdated packages are not deleted, managed packages are not added.
  3. Managed packages are not listed in the readme.

Issue Number: N/A

What is the new behavior?

  1. The following packages are now managed:
    • @angular/cdk
    • @angular/google-maps
    • @angular/material
    • @angular/youtube-player
  2. Outdated packages are not deleted, managed packages are not added.
  3. Managed packages are listed in the readme.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

New behavior introduced because it will start adding more dependencies and delete outdated dependencies. However, this shouldn't affect the consumers. We haven't described how packages are added or removed. It should just magically work as far as the consumer is concerned.

Other information

Version sync strategy for Angular Components packages are documented in CONTRIBUTING.md.

@LayZeeDK LayZeeDK marked this pull request as ready for review May 25, 2021 20:20
@LayZeeDK LayZeeDK requested a review from NachoVazquez May 25, 2021 20:20
@LayZeeDK LayZeeDK changed the title feat: support Angular CDK and Angular Material feat: support Angular Components May 25, 2021

@NachoVazquez NachoVazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I left some doubts in the comments.

Comment thread README.md
Comment thread __tests__/override-angular-versions.test.ts
Comment thread src/override-angular-versions.ts
@LayZeeDK LayZeeDK force-pushed the feat/support-angular-material branch from df03d22 to 94cef4f Compare May 26, 2021 07:25
@LayZeeDK LayZeeDK requested a review from NachoVazquez May 26, 2021 07:32

@NachoVazquez NachoVazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but I left a suggestion for removing the as any conversion in case you think it makes sense.

@LayZeeDK LayZeeDK merged commit 0bcbe20 into main May 28, 2021
@LayZeeDK LayZeeDK deleted the feat/support-angular-material branch May 28, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants