feat: support Angular Components#31
Merged
Merged
Conversation
NachoVazquez
requested changes
May 25, 2021
NachoVazquez
left a comment
Contributor
There was a problem hiding this comment.
Looking good, I left some doubts in the comments.
df03d22 to
94cef4f
Compare
NachoVazquez
approved these changes
May 26, 2021
NachoVazquez
left a comment
Contributor
There was a problem hiding this comment.
I'll approve, but I left a suggestion for removing the as any conversion in case you think it makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
yarn build)PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
@angular/cdk@angular/google-maps@angular/material@angular/youtube-playerDoes this PR introduce a breaking change?
New behavior introduced because it will start adding more dependencies and delete outdated dependencies. However, this shouldn't affect the consumers. We haven't described how packages are added or removed. It should just magically work as far as the consumer is concerned.
Other information
Version sync strategy for Angular Components packages are documented in
CONTRIBUTING.md.