feat!: use local route for local router store#309
Merged
Conversation
…ctors and `Router#events`
e8cc5cb to
ec7c959
Compare
9d49464 to
4b4f938
Compare
4b4f938 to
cc98f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change in implementation will make the local router store more closely match
ActivatedRoutewhile the global router store matches NgRx Router Store selectors. Through complex route configurations, the router store implementations are exercised to identify edge case differences between them and any breaking changes introduced to the local router store.Features
LocalRouterStorematchesActivatedRoutemore closelyActivatedRouteto serialize the router state for the local router store implementation (LocalRouterStore)LocalRouterStore.currentRoute$matchesActivatedRoute.snapshotTesting
LocalRouterStoreselectors toActivatedRouteobservablesGlobalRouterStoreselectors to NgRx Router Store selectors andRouter#eventsBREAKING CHANGES
BEFORE:
(Router Component Store <=0.3.2)
AFTER:
(Router Component Store >0.3.2)