Skip to content

Linq: replace MemoryExtensions.Contains with Enumerable.Contains#3721

Merged
hazzik merged 3 commits into
nhibernate:masterfrom
hazzik:fix-csharp-14
Jun 16, 2026
Merged

Linq: replace MemoryExtensions.Contains with Enumerable.Contains#3721
hazzik merged 3 commits into
nhibernate:masterfrom
hazzik:fix-csharp-14

Conversation

@hazzik

@hazzik hazzik commented Nov 12, 2025

Copy link
Copy Markdown
Member

Fixes #3651

@ValResnick ValResnick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The draft looks good. Let me know if I can help with anything.
It looks like the .NET 10 topic has been moved to a lower priority.
However, this issue is currently blocking our upgrade to .NET 10, so it’s a critical blocker for us at the moment.

@ValResnick ValResnick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@fredericDelaporte

Copy link
Copy Markdown
Member

Is there a reason for this PR to stay as a draft?

@hazzik hazzik marked this pull request as ready for review June 15, 2026 06:41
@hazzik hazzik changed the title fix csharp 14 Linq: replace MemoryExtensions.Contains with Enumerable.Contains Jun 15, 2026
@hazzik

hazzik commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

@fredericDelaporte no reason

@hazzik hazzik merged commit 0e0c649 into nhibernate:master Jun 16, 2026
19 checks passed
@hazzik hazzik deleted the fix-csharp-14 branch June 16, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for "first-class span types" C# 14 language feature

3 participants