Fix panic on HistoryTreeProof length mismatch#3659
Closed
jsdanielh wants to merge 0 commit into
Closed
Conversation
commit: |
viquezclaudio
approved these changes
Mar 27, 2026
jsdanielh
force-pushed
the
fix/history-tree-proof-length-mismatch
branch
from
955b33b to
6ff0800
Compare
Member
Author
|
Merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HistoryTreeProof::verifyusedassert_eq!to check thathistoryandpositionsvectors have equal length. A malicious peer could send a proof with mismatched lengths, panicking the verifying node.Noneon mismatch, consistent with the method's documented error-returning contract.