Multisig: return errors instead of panicking on invalid curve points when delinearizing#3713
Merged
Merged
Conversation
commit: |
viquezclaudio
approved these changes
Apr 22, 2026
…when delinearizing
75c7ec4 to
3bc449a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Ed25519PublicKey::delinearize()called.unwrap()on curve point decompression, which panics when given 32-byte public keys that aren't valid Ed25519 points. SinceEd25519PublicKeyconstruction only validates byte length, not curve membership, this is reachable from untrusted input in wallet and web-client multisig flows.This replaces the panic with
Resultpropagation through thedelinearizecall chain.verify_partial()now returns false on invalid keys, consistent with howverify()already handles them.Commitment::From<[u8; 32]>is changed toTryFrom.Overall API impact is minimal since all external call sites in wallet and web-client already return
ResultorJsError, so the change just adds a?at each call site without altering their public signatures.Only client-side wallet code is affected — no consensus, validator, or network code uses the multisig delinearization path.
Pull request checklist
clippyandrustfmtwarnings.