Trie: reject ROOT-keyed items in put_chunk#3762
Merged
Merged
Conversation
viquezclaudio
approved these changes
May 6, 2026
8820a62 to
0fb8766
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
MerkleRadixTrie::put_chunkprocessesTrieChunkdata from state-sync peers. It validates sorting, key range, and the Merkle proof but does not reject items whose key isKeyNibbles::ROOT(the empty-nibbles root key). When such an item reachesput_raw, the equal-key branch callscur_node.put_value(value).unwrap()on the root node.A malicious sync peer crafts a
ResponseChunk::Chunkwhoseitems[0].key == KeyNibbles::ROOT. ROOT is the lexicographically smallest key, so the sort check passes. The proof verifies because it is over the last item's Merkle path, not every item. The crash fires on the first chunk the node commits.Fix
if !chunk.items.is_empty() { … }block, using the existingInvalidChunkerror variant.items[0]is sufficient because the existing sort check guarantees strictly increasing keys and ROOT is the minimum.Impact
InvalidChunkis already returned for other chunk validation failures;commit_chunksalready aborts the txn, logs a warn, and triggersreset_chunk_request_chain()in the live-sync layer. Honest peers never construct ROOT-keyed items.