Skip to content

Fix panic on HistoryTreeProof length mismatch

Sign in for the full log view
GitHub Actions / Clippy Report succeeded Mar 27, 2026 in 0s

Clippy Report

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.94.1 (e408947bf 2026-03-25)
  • cargo 1.94.1 (29ea6fb6a 2026-03-24)
  • clippy 0.1.94 (e408947bfd 2026-03-25)

Annotations

Check warning on line 118 in pow-migration/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `args.password` after checking its variant with `is_some`

warning: called `unwrap` on `args.password` after checking its variant with `is_some`
   --> pow-migration/src/main.rs:118:67
    |
117 |     let pow_client = if args.username.is_some() && args.password.is_some() {
    |                                                    ----------------------- the check is happening here
118 |         Client::new_with_credentials(url, args.username.unwrap(), args.password.unwrap())
    |                                                                   ^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: try using `if let` or `match`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap

Check warning on line 118 in pow-migration/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `args.username` after checking its variant with `is_some`

warning: called `unwrap` on `args.username` after checking its variant with `is_some`
   --> pow-migration/src/main.rs:118:43
    |
117 |     let pow_client = if args.username.is_some() && args.password.is_some() {
    |                         ----------------------- the check is happening here
118 |         Client::new_with_credentials(url, args.username.unwrap(), args.password.unwrap())
    |                                           ^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: try using `if let` or `match`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap
    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

Check warning on line 158 in consensus/src/sync/light/validity_window.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `self.validity_requests` after checking its variant with `is_some`

warning: called `unwrap` on `self.validity_requests` after checking its variant with `is_some`
   --> consensus/src/sync/light/validity_window.rs:158:33
    |
156 |         if self.validity_requests.is_some() {
    |         ----------------------------------- help: try: `if let Some(<item>) = &self.validity_requests`
157 |             // We already have a synchoronization in progress, so we just add the peer
158 |             let current_chunk = self.validity_requests.as_ref().unwrap().chunk_index;
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap
    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

Check warning on line 394 in blockchain/src/history/merged_history_store.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `self.pre_genesis` after checking its variant with `is_some`

warning: called `unwrap` on `self.pre_genesis` after checking its variant with `is_some`
   --> blockchain/src/history/merged_history_store.rs:392:13
    |
389 |           if epoch_number == 0 && self.pre_genesis.is_some() {
    |                                   -------------------------- the check is happening here
...
392 | /             self.pre_genesis
393 | |                 .as_ref()
394 | |                 .unwrap()
    | |_________________________^
    |
    = help: try using `if let` or `match`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap

Check warning on line 369 in blockchain/src/history/merged_history_store.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `self.pre_genesis` after checking its variant with `is_some`

warning: called `unwrap` on `self.pre_genesis` after checking its variant with `is_some`
   --> blockchain/src/history/merged_history_store.rs:369:17
    |
363 |         if tx_hashes.len() < max as usize && self.pre_genesis.is_some() {
    |                                              -------------------------- the check is happening here
...
369 |                 self.pre_genesis.as_ref().unwrap().get_tx_hashes_by_address(
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: try using `if let` or `match`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap

Check warning on line 82 in blockchain/src/history/merged_history_store.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `self.pre_genesis` after checking its variant with `is_some`

warning: called `unwrap` on `self.pre_genesis` after checking its variant with `is_some`
  --> blockchain/src/history/merged_history_store.rs:80:13
   |
77 |           if Policy::epoch_at(block_number) == 0 && self.pre_genesis.is_some() {
   |                                                     -------------------------- the check is happening here
...
80 | /             self.pre_genesis
81 | |                 .as_ref()
82 | |                 .unwrap()
   | |_________________________^
   |
   = help: try using `if let` or `match`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap
   = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

Check warning on line 733 in primitives/transaction/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `signature_proof.webauthn_fields` after checking its variant with `is_some`

warning: called `unwrap` on `signature_proof.webauthn_fields` after checking its variant with `is_some`
   --> primitives/transaction/src/lib.rs:733:29
    |
730 |                     if signature_proof.webauthn_fields.is_some() {
    |                     -------------------------------------------- help: try: `if let Some(<item>) = &signature_proof.webauthn_fields`
...
733 |                             signature_proof.webauthn_fields.as_ref().unwrap(),
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap

Check warning on line 452 in primitives/transaction/src/signature_proof.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `self.webauthn_fields` after checking its variant with `is_some`

warning: called `unwrap` on `self.webauthn_fields` after checking its variant with `is_some`
   --> primitives/transaction/src/signature_proof.rs:452:50
    |
451 |             if self.webauthn_fields.is_some() {
    |             --------------------------------- help: try: `if let Some(<item>) = &self.webauthn_fields`
452 |                 state.serialize_field(FIELDS[4], self.webauthn_fields.as_ref().unwrap())?;
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap
    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

Check warning on line 733 in primitives/transaction/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `signature_proof.webauthn_fields` after checking its variant with `is_some`

warning: called `unwrap` on `signature_proof.webauthn_fields` after checking its variant with `is_some`
   --> primitives/transaction/src/lib.rs:733:29
    |
730 |                     if signature_proof.webauthn_fields.is_some() {
    |                     -------------------------------------------- help: try: `if let Some(<item>) = &signature_proof.webauthn_fields`
...
733 |                             signature_proof.webauthn_fields.as_ref().unwrap(),
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap

Check warning on line 452 in primitives/transaction/src/signature_proof.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

called `unwrap` on `self.webauthn_fields` after checking its variant with `is_some`

warning: called `unwrap` on `self.webauthn_fields` after checking its variant with `is_some`
   --> primitives/transaction/src/signature_proof.rs:452:50
    |
451 |             if self.webauthn_fields.is_some() {
    |             --------------------------------- help: try: `if let Some(<item>) = &self.webauthn_fields`
452 |                 state.serialize_field(FIELDS[4], self.webauthn_fields.as_ref().unwrap())?;
    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap
    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default