-
-
Notifications
You must be signed in to change notification settings - Fork 814
feat: generate InternalFetch signature #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5fb99e2
feat: generate `InternalFetch` signature
danielroe 44e000a
feat: generate `InternalFetch` signatures
danielroe f3c5c77
style: lint
danielroe b63b567
style: lint more
danielroe 8e3f58f
Merge remote-tracking branch 'origin/main' into feat/typed-inputs
danielroe 7d58869
fix: require options when using non-default method
danielroe a755fb7
Merge remote-tracking branch 'origin/main' into feat/typed-inputs
danielroe 1f87d09
fix: restore generic defaults for `$Fetch`
danielroe b4d2b00
fix: request should extend url/requestinfo
danielroe 4fd5be5
chore: apply automated lint fixes
autofix-ci[bot] 46751d7
fix: revert changes to generics
danielroe e2f769a
test: add failing tests
danielroe c501836
fix: refine extends and skip private routes
danielroe 8b124b4
fix: disallow unmatched urls
danielroe 18350be
Merge remote-tracking branch 'origin/main' into feat/typed-inputs
danielroe cf64788
fix: correctly type `$fetch.{raw/create}`
danielroe 7b3ac30
test: update test with TODO comments for unions
danielroe cd6f2d1
Merge remote-tracking branch 'origin/main' into feat/typed-inputs
danielroe 3a9ba18
chore: apply automated lint fixes
autofix-ci[bot] 357e1e4
fix: add back string types for `NitroFetchRequest`
danielroe 7290307
test: add additional case
danielroe 17ba1b3
fix: reuse type
danielroe fd7d1fc
fix: improve type safety with optional options param
danielroe 854a5e3
fix: improve error message when no route is matched
danielroe 2cc871f
chore: apply automated lint fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export default eventHandler<{ query: { id: string } }, string>(() => 'foo'); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.