Skip to content

Propagate bcachefs_filesystem mountOptions to subvolumes#1171

Open
VlaDexa wants to merge 1 commit intonix-community:masterfrom
VlaDexa:bcachefs-propogate-mountOptions
Open

Propagate bcachefs_filesystem mountOptions to subvolumes#1171
VlaDexa wants to merge 1 commit intonix-community:masterfrom
VlaDexa:bcachefs-propogate-mountOptions

Conversation

@VlaDexa
Copy link
Copy Markdown

@VlaDexa VlaDexa commented Dec 4, 2025

Make subvolume mountOptions also include options for the whole
filesystem, but only when the filesystems mountpoint is not specified

My reasoning behind this is that if user specifies mountOptions for the filesystem, but doesn't mount it, it's likely they want those options to apply to subvolumes of that filesystem.

@VlaDexa VlaDexa force-pushed the bcachefs-propogate-mountOptions branch from 72e424f to a277dec Compare December 4, 2025 21:52
Make subvolume mountOptions also include options for the whole
filesystem, but only when the filesystems mountpoint is not specified
@VlaDexa VlaDexa force-pushed the bcachefs-propogate-mountOptions branch from a277dec to 992f919 Compare December 4, 2025 21:56
@VlaDexa VlaDexa changed the title Propagate filesystem mountOptions to subvolumes Propagate bcachefs_filesystem mountOptions to subvolumes Dec 4, 2025
@nothingnesses
Copy link
Copy Markdown
Contributor

nothingnesses commented Dec 14, 2025

It might be worth either modifying the mounted_subvolumes_in_multi example in https://github.com/nix-community/disko/blob/master/example/bcachefs.nix (which doesn't have a mountpoint, so it should be suitable for this) or adding a new entry in bcachefs_filesystems, to add one or more mountOptions that will be applied to all its subvolumes, as well as updating or adding the corresponding test in https://github.com/nix-community/disko/blob/master/tests/bcachefs.nix , to demonstrate this works properly.

Alternatively, it might instead be worth adding an explicit subvolumesMountOptions configuration option for the bcachefs_filesystem type that can be used to apply the mount options listed to all its subvolumes, which I think would be less confusing. It'd be good to have corresponding examples and tests for this too.

Alternatively, you can just set the mountOptions for each of the subvolumes manually, which would require no code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants