Skip to content

Add AF_ALG socket types and related control mesages and sockopts on Linux and Andorid#1031

Merged
bors[bot] merged 1 commit intonix-rust:masterfrom
glebpom:crypto-api
Mar 16, 2019
Merged

Add AF_ALG socket types and related control mesages and sockopts on Linux and Andorid#1031
bors[bot] merged 1 commit intonix-rust:masterfrom
glebpom:crypto-api

Conversation

@glebpom
Copy link
Copy Markdown
Contributor

@glebpom glebpom commented Feb 20, 2019

No description provided.

asomers
asomers requested changes Feb 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but it needs a CHANGELOG entry and some tests. Also, is there any way for a program to receive AF_ALG control messages or can they only be sent? If they can be received, then you'll have to add them to ControlMessageOwned.

Comment thread src/sys/socket/mod.rs Outdated
asomers
asomers reviewed Feb 20, 2019
View reviewed changes
Comment thread test/sys/test_socket.rs Outdated
Comment thread test/sys/test_socket.rs Outdated
Comment thread test/sys/test_socket.rs Outdated
Comment thread test/sys/test_socket.rs
@glebpom glebpom changed the title Support AF_ALG Control Messages Add ALG_SET_IV, ALG_SET_OP and ALG_SET_AEAD_ASSOCLEN control messages and AF_ALG socket types on Linux and Andorid Feb 21, 2019
@glebpom glebpom changed the title Add ALG_SET_IV, ALG_SET_OP and ALG_SET_AEAD_ASSOCLEN control messages and AF_ALG socket types on Linux and Andorid Add AF_ALG socket types and related control mesages and sockopts on Linux and Andorid Feb 21, 2019
asomers
asomers reviewed Feb 21, 2019
View reviewed changes
Comment thread src/sys/socket/mod.rs Outdated
Comment thread src/sys/socket/addr.rs Outdated
Comment thread src/sys/socket/sockopt.rs Outdated
Comment thread src/sys/socket/addr.rs Outdated
Comment thread src/sys/socket/mod.rs Outdated
Comment thread src/sys/socket/mod.rs Outdated
Comment thread src/sys/socket/mod.rs Outdated
Comment thread src/sys/socket/addr.rs Outdated
@glebpom
Copy link
Copy Markdown
Contributor Author

glebpom commented Feb 21, 2019

Just seen the Unsupported setsockopt level=279 optname=1 error here. Will take a deeper look.

@glebpom
Copy link
Copy Markdown
Contributor Author

glebpom commented Feb 22, 2019

Qemu requires explicit enabling of AF_ALG (source code)
It's not enabled in cross

@asomers
Copy link
Copy Markdown
Member

asomers commented Feb 22, 2019

Qemu requires explicit enabling of AF_ALG (source code)
It's not enabled in cross

Makes sense. Could you embed that information in a comment in the code?

@glebpom
Copy link
Copy Markdown
Contributor Author

glebpom commented Feb 23, 2019

Tests failed on MacOS targets. I think it doesn't relate to this PR.

@asomers asomers mentioned this pull request Mar 1, 2019
Merged
@asomers
Copy link
Copy Markdown
Member

asomers commented Mar 6, 2019

To fix the tests, you need to rebase.

@glebpom glebpom force-pushed the crypto-api branch 2 times, most recently from 256e371 to bf557ad Compare March 6, 2019 16:10
@glebpom
Copy link
Copy Markdown
Contributor Author

glebpom commented Mar 7, 2019

Done. It should be good now.

asomers
asomers reviewed Mar 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ok now; it only needs a squash.

@glebpom
Copy link
Copy Markdown
Contributor Author

glebpom commented Mar 13, 2019

Done

asomers
asomers approved these changes Mar 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 16, 2019
@bors
Merge #1031
426c292 
1031: Add AF_ALG socket types and related control mesages and sockopts on Linux and Andorid r=asomers a=glebpom



Co-authored-by: Gleb Pomykalov <gleb@lancastr.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Mar 16, 2019

Build succeeded

@bors bors bot merged commit 6968cb4 into nix-rust:master Mar 16, 2019
@gnzlbg gnzlbg mentioned this pull request Sep 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asomers asomers asomers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glebpom @asomers
⚡