Properly initialize msghdr when using musl#1136
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom Oct 15, 2019
yshui:master
Merged
Properly initialize msghdr when using musl#1136bors[bot] merged 1 commit intonix-rust:masterfrom yshui:master
bors[bot] merged 1 commit intonix-rust:masterfrom
yshui:master
Conversation
Member
|
Thanks @yshui change LGTM. Can you amend the commit with a changelog addition per https://github.com/nix-rust/nix/blob/master/CONTRIBUTING.md#pull-requests |
Because of the use of MaybeUninit::uninit, the padding fields in msghdr, which only present on musl builds, are not initialized. Causing garbage data to be sent to the kernel. This change ensures the paddings are always zeroed.
Contributor
Author
|
@posborne Done! |
bors bot
added a commit
that referenced
this pull request
Oct 15, 2019
1136: Properly initialize msghdr when using musl r=posborne a=yshui Because of the use of MaybeUninit::uninit, the padding fields in msghdr, which only present on musl builds, are not initialized. Causing garbage data to be sent to the kernel. This change ensures the paddings are always zeroed. Co-authored-by: Yuxuan Shui <yshuiv7@gmail.com>
Contributor
Build succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the use of MaybeUninit::uninit, the padding fields in msghdr,
which only present on musl builds, are not initialized. Causing garbage
data to be sent to the kernel. This change ensures the paddings are
always zeroed.