Add Users and Group related functions#1139
Add Users and Group related functions#1139bors[bot] merged 1 commit intonix-rust:masterfrom otavio:add-user-group-support
Users and Group related functions#1139Conversation
|
So what's the plan? What do you expect to add in a follow up PR? |
|
@asomers we did not include the iterators here and I'd like to extend it after this is merged as it is independent and allow for reducing the code to work/review. Do you mind to go over this here so we clean any leftover and merge this one? |
|
@asomers any comment on this one? |
asomers
left a comment
There was a problem hiding this comment.
Looks good! I'm almost inclined to merge as-is, except for the one issue I raised inline. Also, it needs a CHANGELOG entry.
|
@asomers I made the changes. Please let me know if something else is still needed. |
|
Now that you no longer |
This was a collaborative work between Johannes Schilling <dario@deaktualisierung.org>, Fredrick Brennan <copypaste@kittens.ph> and myself. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Just did; sorry for missing that. |
|
@asomers fixed the unnecessary |
This was a collaborative work between Johannes Schilling <dario@deaktualisierung.org>, Fredrick Brennan <copypaste@kittens.ph> and myself. This is a continuation of nix-rust#1139. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
1139: Add `Users` and `Group` related functions r=asomers a=otavio This was a collaborative work between Johannes Schilling <dario@deaktualisierung.org>, Fredrick Brennan <copypaste@kittens.ph> and myself. This PR is a split-off from #864 so we merge ready parts first. Next, we work on the iterators. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Co-authored-by: Otavio Salvador <otavio@ossystems.com.br>
Build succeeded
|
This was a collaborative work between Johannes Schilling
dario@deaktualisierung.org, Fredrick Brennan copypaste@kittens.ph
and myself.
This PR is a split-off from #864 so we merge ready parts first. Next, we work on the iterators.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br