Remove deprecated Error::description#1175
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom Jan 10, 2020
Merged
Conversation
asomers
requested changes
Dec 28, 2019
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Thanks for this submission. Just one more thing: could you please add a CHANGELOG entry?
AnderEnder
force-pushed
the
remove-deprecated-error-description
branch
from
9dd3854 to
edb2632
Compare
Contributor
Author
|
@asomers, CHANGELOG was updated. |
Contributor
Author
|
@asomers any news? |
bors bot
added a commit
that referenced
this pull request
Jan 10, 2020
1175: Remove deprecated Error::description r=asomers a=AnderEnder `Error::description` has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon. This PR: - Removes all implementations of `description` in all error types Related PR: rust-lang/rust#66919 Co-authored-by: Radyk Andrii <ander.ender@gmail.com>
Contributor
Build succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error::descriptionhas been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.This PR:
descriptionin all error typesRelated PR: rust-lang/rust#66919