Skip to content

Add CLK_TCK to SysconfVar#1177

Merged
bors[bot] merged 1 commit intonix-rust:masterfrom
cjbassi:master
Jan 12, 2020
Merged

Add CLK_TCK to SysconfVar#1177
bors[bot] merged 1 commit intonix-rust:masterfrom
cjbassi:master

Conversation

@cjbassi
Copy link
Copy Markdown
Contributor

@cjbassi cjbassi commented Jan 11, 2020

http://man7.org/linux/man-pages/man3/sysconf.3.html says that the
corresponding variable is obsolete, but I think that just means the
constant defined in limits.h is obsolete. Checking the value using
sysconf is still valid.

@asomers
Copy link
Copy Markdown
Member

asomers commented Jan 11, 2020

I think you're correct. Could you please add a CHANGELOG entry?

@cjbassi
Copy link
Copy Markdown
Contributor Author

cjbassi commented Jan 12, 2020

Done.

@asomers
Copy link
Copy Markdown
Member

asomers commented Jan 12, 2020

Good. Please squash your commits, and I'll merge them. I can't simply use Github's squash button, because we merge with bors.

http://man7.org/linux/man-pages/man3/sysconf.3.html says that the
corresponding variable is obsolete, but I think that just means the
constant defined in limits.h is obsolete. Checking the value using
sysconf is still valid.
@cjbassi
Copy link
Copy Markdown
Contributor Author

cjbassi commented Jan 12, 2020

Just squashed.

Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jan 12, 2020
1177: Add CLK_TCK to SysconfVar r=asomers a=cjbassi

http://man7.org/linux/man-pages/man3/sysconf.3.html says that the
corresponding variable is obsolete, but I think that just means the
constant defined in limits.h is obsolete. Checking the value using
sysconf is still valid.

Co-authored-by: Caleb Bassi <calebjbassi@gmail.com>
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Jan 12, 2020

Build succeeded

@bors bors bot merged commit 6e5e3ab into nix-rust:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants