Skip to content

Enable getregs/setregs on x86_64 musl#1198

Merged
bors[bot] merged 1 commit intonix-rust:masterfrom
coord-e:musl-getregs-setregs
Apr 1, 2020
Merged

Enable getregs/setregs on x86_64 musl#1198
bors[bot] merged 1 commit intonix-rust:masterfrom
coord-e:musl-getregs-setregs

Conversation

@coord-e
Copy link
Copy Markdown
Contributor

@coord-e coord-e commented Mar 19, 2020

Hi, I needed ptrace::getregs in my project. I noticed that they're only enabled on glibc while they can be compiled with musl. This PR enables getregs/setregs on x86_64 musl libc environment.

coord-e added a commit to coord-e/nix that referenced this pull request Mar 19, 2020
coord-e added a commit to coord-e/nix that referenced this pull request Mar 19, 2020
@coord-e coord-e force-pushed the musl-getregs-setregs branch from b47bd57 to ae5b6d6 Compare March 19, 2020 17:37
@coord-e coord-e changed the title Enable getregs/setregs on musl Enable getregs/setregs on x86_64 musl Mar 19, 2020
@asomers
Copy link
Copy Markdown
Member

asomers commented Mar 27, 2020

This looks good; now please squash your commits. The CI failure I think is caused by a bug in glibc.

coord-e added a commit to coord-e/nix that referenced this pull request Mar 28, 2020
@coord-e coord-e force-pushed the musl-getregs-setregs branch from ae5b6d6 to 6c57c10 Compare March 28, 2020 06:35
@coord-e
Copy link
Copy Markdown
Contributor Author

coord-e commented Mar 28, 2020

Squashed and pushed. Thanks

@asomers
Copy link
Copy Markdown
Member

asomers commented Apr 1, 2020

Sorry, but you'll have to rebase. Some other PR just made a conflict.

coord-e added a commit to coord-e/nix that referenced this pull request Apr 1, 2020
@coord-e coord-e force-pushed the musl-getregs-setregs branch from 6c57c10 to 13cce09 Compare April 1, 2020 15:27
@coord-e coord-e force-pushed the musl-getregs-setregs branch from 13cce09 to 87047fc Compare April 1, 2020 15:28
@coord-e
Copy link
Copy Markdown
Contributor Author

coord-e commented Apr 1, 2020

That's OK, I've rebased

Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Apr 1, 2020

Build succeeded

@bors bors bot merged commit 627dff9 into nix-rust:master Apr 1, 2020
@coord-e coord-e deleted the musl-getregs-setregs branch April 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants