Merged
Conversation
Member
|
Please add a CHANGELOG entry. |
GuillaumeDIDIER
added a commit
to GuillaumeDIDIER/nix
that referenced
this pull request
Apr 20, 2020
Contributor
Author
|
Done. Sorry about forgetting this. |
asomers
reviewed
Apr 21, 2020
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Looks good. But could I please ask you to squash your commits?
Closes nix-rust#1194 Use git libc for development (Remember to reset this to released version for the next nix release, once libc has released >=0.2.69)
GuillaumeDIDIER
force-pushed
the
feature/hugepage-size
branch
from
6fb8024 to
d7a725d
Compare
Contributor
Author
|
Squashed. |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve #1194 .