Remove sys::socket::addr::from_libc_sockaddr from the public API#1215
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom May 1, 2020
Merged
Remove sys::socket::addr::from_libc_sockaddr from the public API#1215bors[bot] merged 1 commit intonix-rust:masterfrom
bors[bot] merged 1 commit intonix-rust:masterfrom
Conversation
This function never should've been public, since it's basically impossible to use directly. It's only public due to an oversight from PR nix-rust#667 .
Member
Author
Contributor
|
Build succeeded: |
Contributor
|
This would actually be really useful to me; it's not impossible to use directly if you're doing FFI and get a |
Member
Author
What is your use case? How are you getting the |
Contributor
|
Well I suppose I actually have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function never should've been public, since it's basically
impossible to use directly. It's only public due to an oversight from
PR #667 .