Replace void crate with Rust standard lib Infallible type#1239
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom May 17, 2020
Merged
Replace void crate with Rust standard lib Infallible type#1239bors[bot] merged 1 commit intonix-rust:masterfrom
bors[bot] merged 1 commit intonix-rust:masterfrom
Conversation
asomers
requested changes
May 16, 2020
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Yep, this change looks good. But could you please add a link to the PR in the CHANGELOG section?
std::convert::Infallible has been available since Rust 1.34 and nix currently targets Rust 1.36 or later so this should not cause problems. Fixes nix-rust#1238
Contributor
Author
|
@asomers Changelog fixed. Thanks! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::convert::Infalliblehas been available since Rust 1.34 and nix currently targets Rust 1.36 or later so this should not cause problems.Fixes #1238