Allow both &[CString] and &[&CStr] for sequence args in unistd#1278
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom Aug 22, 2020
Merged
Allow both &[CString] and &[&CStr] for sequence args in unistd#1278bors[bot] merged 1 commit intonix-rust:masterfrom
bors[bot] merged 1 commit intonix-rust:masterfrom
Conversation
asomers
requested changes
Jul 27, 2020
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Yes, that sounds like a good change. Could you please add a CHANGELOG entry? We also require tests for all new functionality. These functions already have some tests in test/test_unistd.rs. But it might be more appropriate in this case to add some doc tests.
Contributor
Author
|
I fixed |
Contributor
Author
|
@asomers would you review this PR again? |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am new to this project, so I wonder this kind of change is acceptable for the project or not.
I agree taking
&[&CStr]is the ideal way for the functions. But unfortunately, when users generateCStrings from&str, they may get&[CString]rather than&[&CStr]Unlike single
CStringto&CStrargument, there is no easy way to convert&[CString]to&[&CStr]without creating new vector.By changing the type from
&[&CStr]to&[AsRef<CStr>], the args now can take both&[CString]and&[&CStr]without changing that much from nix.