Mark nix::unistd::fork as unsafe.#1293
Merged
bors[bot] merged 2 commits intonix-rust:masterfrom Oct 3, 2020
Merged
Conversation
Contributor
Author
|
r? @asomers |
asomers
requested changes
Sep 11, 2020
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Since this change is backwards-incompatible, it needs a good explanation in the CHANGELOG. Could you please add one?
Contributor
Author
|
Added changelog entry. |
Member
|
Now the compiler is complaining about "unnecessary unsafe block". Can you please fix those? |
Contributor
Author
|
It is not caused by the changed code, it's just master brach is not buildable anymore. I submitted a separate pull request with an easy way to fix it: #1294. |
Fix tests. No change in documentation. Resolves nix-rust#1030.
Contributor
Author
|
@asomers Rebased the pull request. |
Contributor
Author
|
@asomers, Shall something more be done about this pull request? |
asomers
approved these changes
Oct 3, 2020
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Nope. I think it's good to go.
bors r+
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests. No change in documentation.
Resolves #1030.
Don't forget to bump major version number to
0.19.