feat(unistd): Add getpeereid(3)#1342
Conversation
|
N.B. I added this to OpenBSD exposes it in |
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
This looks pretty good so far. Don't forget to add a CHANGELOG entry.
|
I noticed that my editor cleaned up some trailing whitespace in the files that I modified. Let me know if you want me to prune those changes from this PR. |
|
You should also add |
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Could you please squash your commits before we merge this PR?
|
Whoops, will add it.
Sent from mobile. Please excuse my brevity.
… On Nov 28, 2020, at 4:36 PM, Alan Somers ***@***.***> wrote:
@asomers requested changes on this pull request.
Could you please squash your commits before we merge this PR?
In test/test_unistd.rs:
> @@ -1044,3 +1044,41 @@ fn test_ttyname_invalid_fd() {
fn test_ttyname_invalid_fd() {
assert_eq!(ttyname(-1), Err(Error::Sys(Errno::ENOTTY)));
}
+
+#[test]
+#[cfg(any(
+ target_os = "macos",
Why no dragonfly for this test?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
woodruffw
force-pushed
the
ww/getpeereid
branch
from
4e4a994 to
1299538
Compare
|
This looks good now. The only thing it needs is to squash the commits and remove unrelated formatting changes. |
|
Okay, rebased. Let me know if there's anything else I can do. |
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw `getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports). Closes #1339. Co-authored-by: William Woodruff <william@yossarian.net>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
|
Merge conflict. |
woodruffw
force-pushed
the
ww/getpeereid
branch
3 times, most recently
from
354b3c6 to
000e671
Compare
|
Rebased again, and killed the whitespace changes. |
|
bors r+ |
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw `getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports). Closes #1339. Co-authored-by: William Woodruff <william@yossarian.net>
|
Timed out. |
|
bors retry |
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw `getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports). Closes #1339. Co-authored-by: William Woodruff <william@yossarian.net>
|
Timed out. |
|
This is Travis's fault. The current build has been waiting for more than 6 hours to start. I'll again late at night. |
Got it, thanks. It sounds like they cut back quotas for OSS projects recently 😞 |
|
Try rebasing now. |
woodruffw
force-pushed
the
ww/getpeereid
branch
from
000e671 to
8ca6e20
Compare
|
Okay, rebased. Let me know if there's anything else I can do. |
|
Try rebasing again. |
woodruffw
force-pushed
the
ww/getpeereid
branch
from
8ca6e20 to
fff75b4
Compare
|
Rebased! |
woodruffw
force-pushed
the
ww/getpeereid
branch
from
fff75b4 to
ae25804
Compare
1342: feat(unistd): Add getpeereid(3) r=asomers a=woodruffw `getpeereid(3)` is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (compare `getsockopt` + `SO_PEERCRED` on Linux, which `nix` already supports). Closes #1339. Co-authored-by: William Woodruff <william@yossarian.net>
|
Hmm, bors has been stuck for a few days now. Might need manual intervention? |
|
It was a bug in our bors configuration, since fixed. You'll have to rebase again. |
woodruffw
force-pushed
the
ww/getpeereid
branch
from
ae25804 to
e0b9eb5
Compare
|
Okay, rebased again. Also killed off some whitespace that I added to the CHANGELOG by mistake. |
woodruffw
force-pushed
the
ww/getpeereid
branch
from
e0b9eb5 to
7c3a353
Compare
|
Thanks! |
3 participants
getpeereid(3)is not POSIX, but it's present on many BSD-derived Unices. It's also the standard mechanism on those OSes for retrieving socket peer credentials (comparegetsockopt+SO_PEERCREDon Linux, whichnixalready supports).Closes #1339.