Fix corrupted sendmmsg() call#1414
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom Apr 8, 2021
Merged
Conversation
asomers-ax
reviewed
Apr 3, 2021
Contributor
asomers-ax
left a comment
asomers-ax
left a comment
There was a problem hiding this comment.
Good find! Would you mind adding a CHANGELOG entry?
Contributor
Author
|
Added, thanks. |
asomers
requested changes
Apr 7, 2021
asomers
reviewed
Apr 7, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Looks good, but please squash your commits.
Before this fix, the buffer that holds cmsgs may move due to the resize() call. That causes msg_hdr pointing to invalid memory, which ends up breaking the sendmmsg() call, resulting in EINVAL. This change fixes it by avoiding re-allocating the buffers.
Contributor
Author
|
Squashed with the updated commit message |
bors bot
added a commit
that referenced
this pull request
Apr 8, 2021
1414: Fix corrupted sendmmsg() call r=asomers a=eaufavor Before this fix, the buffer that holds cmsgs may move due to the resize() call. That causes msg_hdr pointing to invalid memory, which ends up breaking the sendmmsg() call, resulting in EINVAL. This change fixes it by avoiding re-allocating the buffers. Co-authored-by: Yuchen Wu <yuchen@cloudflare.com>
Contributor
|
Build failed: |
Member
|
bors retry |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, the buffer that holds cmsgs may move due to the resize()
call. That causes msg_hdr pointing to invalid memory, which ends up
breaking the sendmmsg() call, resulting in EINVAL.
This change fixes it by avoiding re-allocating the buffers.