constify from_raw and as_raw for Uid, Gid and Pid and Uid::is_root#1429
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom May 1, 2021
Merged
constify from_raw and as_raw for Uid, Gid and Pid and Uid::is_root#1429bors[bot] merged 1 commit intonix-rust:masterfrom
bors[bot] merged 1 commit intonix-rust:masterfrom
Conversation
Contributor
Author
|
I don't think the failed check is due to this patch... |
asomers
requested changes
Apr 23, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Thanks for the patch. Other than a PR link to the CHANGELOG, it looks good.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Blub
force-pushed
the
constify-uid-gid-pid
branch
from
9c65e34 to
8fa391c
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make some integer wrapper methods
const fn.Uid::from_rawUid::as_rawUid::is_rootGid::from_rawGid::as_rawPid::from_rawPid::as_raw(Changelog mentions rust 1.40.0 as minimum required version which seems to compile this fine (using 1.40.0 from rustup))