Expose SockAddr::from_raw_sockaddr#1447
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom Aug 22, 2021
Merged
Conversation
asomers
requested changes
Jun 12, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Could you please split these two changes up, since they're unrelated? Also, it would be good to deprecate to_str for a few releases before removing it entirely.
coolreader18
force-pushed
the
sockaddr-from-raw
branch
from
83c0117 to
202e408
Compare
Contributor
Author
bors bot
added a commit
that referenced
this pull request
Aug 21, 2021
1447: Expose SockAddr::from_raw_sockaddr r=asomers a=coolreader18 I also noticed the `SockAddr/InetAddr::to_str` functions were entirely redundant - `ToString` exists for that, & has a blanket impl on `T: Display`. Co-authored-by: Noah <33094578+coolreader18@users.noreply.github.com>
Contributor
|
Build failed: |
coolreader18
force-pushed
the
sockaddr-from-raw
branch
from
202e408 to
ed43d2c
Compare
Contributor
Author
|
Huh. I think the failure was just cause of the conflict in CHANGELOG? |
Member
|
bors retry |
Contributor
Contributor
Author
|
Ah, shoot, just realized the functionality I was looking for was in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also noticed the
SockAddr/InetAddr::to_strfunctions were entirely redundant -ToStringexists for that, & has a blanket impl onT: Display.