Enable creating a const TimeSpec#1465
Merged
bors[bot] merged 3 commits intonix-rust:masterfrom Jul 24, 2021
Merged
Conversation
Previously, there was no way to create a TimeSpec in a const context because all creation was through traits. This adds two utility functions to create a const TimeSpec from a libc::timespec or a std::time::Duration
asomers
requested changes
Jul 14, 2021
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
I think this looks good. Would you mind adding a CHANGELOG entry?
Contributor
Author
|
I think this is the correct way to add an entry -- is this the first change for this version? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was no way to create a
TimeSpecin aconstcontext because all creation was through traits. This adds two utility functions to create aconst TimeSpecfrom alibc::timespecor anstd::time::Duration.An alternative approach would be to make the inner
timespecfieldpub, which would not require any additional functions but would expose some (potentially unwanted) implementation details.