Skip to content

Add more errno definitions for better backwards compat with 0.21.0#1467

Merged
bors[bot] merged 1 commit intonix-rust:masterfrom
asomers:more_errnos
Jul 15, 2021
Merged

Add more errno definitions for better backwards compat with 0.21.0#1467
bors[bot] merged 1 commit intonix-rust:masterfrom
asomers:more_errnos

Conversation

@asomers
Copy link
Copy Markdown
Member

@asomers asomers commented Jul 14, 2021

Fixes #1464

@asomers
Copy link
Copy Markdown
Member Author

asomers commented Jul 14, 2021

@sporksmith would the changes in this PR make the 0.21.0 -> 0.22.X upgrade easier for projects like yours?

@sporksmith
Copy link
Copy Markdown
Contributor

Yes, it looks like this would've turned some of the errors into warnings. In our particular case there were few enough that I just fixed all the errors and warnings at once, but I imagine this could be helpful for other projects.

@sporksmith
Copy link
Copy Markdown
Contributor

Fixes #1464

Did you mean #1466? Btw there was another kind of error that looks like wasn't included in the truncated error list in the compiler output I shared there; will add on to #1466 since I think it'd be orthogonal to this PR.

@asomers
Copy link
Copy Markdown
Member Author

asomers commented Jul 15, 2021

bors r+

@bors bors bot merged commit 1a78595 into nix-rust:master Jul 15, 2021
@asomers asomers deleted the more_errnos branch July 24, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants