Skip to content

Restore conversions from ip v4/6 Sockaddr types to std::net equivalents.#1711

Merged
bors[bot] merged 1 commit intonix-rust:masterfrom
khuey:sockaddrin_std_conv
May 3, 2022
Merged

Restore conversions from ip v4/6 Sockaddr types to std::net equivalents.#1711
bors[bot] merged 1 commit intonix-rust:masterfrom
khuey:sockaddrin_std_conv

Conversation

@khuey
Copy link
Copy Markdown
Contributor

@khuey khuey commented Apr 28, 2022

Fixes #1710

@asomers
Copy link
Copy Markdown
Member

asomers commented Apr 28, 2022

How about a mention in the Added section of CHANGELOG?

@rtzoeller
Copy link
Copy Markdown
Collaborator

@khuey can you rebase to fix the CHANGELOG conflict? I updated the file with the expected format in another PR.

@khuey khuey force-pushed the sockaddrin_std_conv branch from 056cdc7 to 024c0d7 Compare May 2, 2022 15:53
@khuey
Copy link
Copy Markdown
Contributor Author

khuey commented May 2, 2022

@khuey can you rebase to fix the CHANGELOG conflict? I updated the file with the expected format in another PR.

Done

Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@bors bors bot merged commit 3109a6d into nix-rust:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InetAddr replacements are not convertible to libstd types?

3 participants