Add From<uid_t> and From<gid_t>#1727
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom May 30, 2022
Merged
Conversation
rtzoeller
reviewed
May 30, 2022
rtzoeller
approved these changes
May 30, 2022
Collaborator
rtzoeller
left a comment
rtzoeller
left a comment
There was a problem hiding this comment.
Thanks! Can you address a minor CHANGELOG nitpick and then squash everything into one commit?
Implements the following traits: * From<uid_t> for Uid * From<gid_t> for Gid
Contributor
Author
|
All comments addressed. Good to go. |
Collaborator
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversions to/from primitive uid_t and gid_t to newtype Uid and Gid types are valid and infallible, but are only implemented in one direction. This provides the counterparts in the other direction.
These conversions are identical in behavior to the from_raw methods. However, using the more idiomatic From trait enables easier interoperability with other crates (e.g., deserialization with serde)