Fix socket address family checks

[qwandor]

The SockaddrLike::from_raw implementations for VsockAddr and SysControlAddr were checking against the wrong address family constant. This PR makes them consistent with the values matched against in SockaddrStorage::from_raw.

[asomers]

Ahh, thank you. That's probably a copy/paste error on my part. Could you please add a "Fixed" entry to CHANGELOG?

[qwandor]

Done.

[rtzoeller]

@asomers any idea what's going on with the FreeBSD 14 timeouts? I've noticed that on a few recent PRs.

I have a fix submitted for Haiku, we're just waiting on a new nightly rustc to be available.

[asomers]

No, I saw that too but I haven't had time to investigate yet.

[asomers]

It looks like test_acct is the culprit. When I run it locally its runtime varies anywhere from a few seconds to 3m. It's just a matter of when does the kernel decide to flush the accounting file, and I don't think userland has any control over that.

[rtzoeller]

@asomers this seems like another patch candidate.

[rtzoeller]

bors r+

[bors]

Build succeeded:

• Android aarch64
• Android arm
• Android armv7
• Android i686
• Android x86_64
• DragonFly BSD x86_64
• FreeBSD 12 amd64 & i686
• FreeBSD 14 amd64 & i686
• Fuchsia x86_64
• Haiku x86_64
• Illumos
• iOS aarch64
• iOS x86_64
• Linux aarch64
• Linux arm gnueabi
• Linux arm-musleabi
• Linux armv7 gnueabihf
• Linux armv7 uclibceabihf
• Linux i686
• Linux i686 musl
• Linux MIPS
• Linux MIPS64
• Linux MIPS64 el
• Linux mipsel
• Linux powerpc
• Linux powerpc64
• Linux powerpc64le
• Linux s390x
• Linux x32
• Linux x86_64
• Linux x86_64 musl
• macOS aarch64
• macOS x86_64
• Minver
• NetBSD x86_64
• OpenBSD x86_64
• Redox x86_64
• Rust Stable

[qwandor]

Hi, any idea when you plan to push a release with this fix included?

[asomers]

I think the only remaining issue that we should consider for a patch release is #1709 , if indeed that turns out to be a bug in Nix.

[rtzoeller]

@qwandor this should be in a 0.24.2 patch release now.