fix bugs on android armv7, because pw.pw_passwd.is_null()#1824
Merged
bors[bot] merged 1 commit intonix-rust:masterfrom Sep 24, 2022
Merged
fix bugs on android armv7, because pw.pw_passwd.is_null()#1824bors[bot] merged 1 commit intonix-rust:masterfrom
pw.pw_passwd.is_null()#1824bors[bot] merged 1 commit intonix-rust:masterfrom
Conversation
Collaborator
|
How are you testing these changes - something like Termux? I'd like to see if I can reproduce this on my end. Thanks! |
Author
|
@rtzoeller use $ adb push <path-to-exec> /data/local/tmp
$ adb shell /data/local/tmp/<exec-file>Rust code: Crash also happened on aarch64 android platform. |
Collaborator
|
Thanks! Confirmed this reproduces for me. Can you add an entry to the CHANGELOG.md file under the |
Collaborator
|
@ClarkGuan can you squash the current two commits into a single commit? |
Author
|
@rtzoeller OK. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crash on my Android phone because
pw.pw_passwd == NULL