Conversation
|
@SUPERCILEX barring a compelling reason to get this PR and #1855 merged ASAP, I'm tempted to submit #1860 and hold these until after the next release (which I would like to publish after working through the latest series of PRs, which I've admittedly fallen behind on). Practically speaking that would only delay these PRs from being submitted by a few weeks, and since they are largely technical debt I don't see a need for them to land in a release urgently. Any reason to deviate from that? There is still a large percentage of users on versions earlier than 0.24.0, so waiting a bit longer feels reasonable. @asomers how do you feel about a |
|
That sounds super reasonable to me, happy to let these sit until the next release. :) |
|
I agree. Let's do 0.26.0 after #1871 merges, and put this PR into the subsequent release. |
|
@SUPERCILEX can you rebase this? I'm happy to submit it whenever it's updated. |
|
Sweet, done! |
|
Lol, that was fast. I think the macOS aarch64 job borked itself for unrelated reasons. |
Yeah, it seems unhappy for reasons unrelated to this PR. I'll re-kick that in a few hours and see if anything has changed. While we're here though, would it be possible to get a changelog note added to this and #1855? I'd like to be clear that we're gutting the deprecated APIs. |
|
Oops, yep, fixed! |
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
3 participants
This one's a little more questionable since it's only been one release, but it removes a ton of code which is sweet.