Skip to content

Added CANbus socket family protocol constants.#1912

Merged
bors[bot] merged 1 commit intonix-rust:masterfrom
fpagliughi:canbus-protocols
Dec 14, 2022
Merged

Added CANbus socket family protocol constants.#1912
bors[bot] merged 1 commit intonix-rust:masterfrom
fpagliughi:canbus-protocols

Conversation

@fpagliughi
Copy link
Copy Markdown
Contributor

Added CANbus socket family protocol values for CanRaw and CanBcm

Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CHANGELOG.

@fpagliughi fpagliughi requested a review from asomers December 9, 2022 23:33
Comment thread CHANGELOG.md Outdated
Comment thread src/sys/socket/mod.rs Outdated
@fpagliughi
Copy link
Copy Markdown
Contributor Author

fpagliughi commented Dec 11, 2022

It looks like a CI task failed due to an artificial limit on the number of community tasks. But I can't figure out how to rerun the check(s) from my end.

@fpagliughi fpagliughi requested a review from asomers December 11, 2022 18:29
Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now you just need to squash your commits. The failed CI job completed after I restarted it.

Copy link
Copy Markdown
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@fpagliughi
Copy link
Copy Markdown
Contributor Author

Thanks, @asomers

@bors bors bot merged commit b7cb456 into nix-rust:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants