add vsock support for macOS#2056
Merged
bors[bot] merged 2 commits intonix-rust:masterfrom Aug 6, 2023
Merged
Conversation
tzneal
force-pushed
the
add-vsock-support-for-macos
branch
2 times, most recently
from
268bec3 to
7b892bf
Compare
asomers
requested changes
Jul 17, 2023
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
This needs a CHANGELOG. Also, I think there will be a merge conflict in Cargo.toml if you don't rebase.
tzneal
force-pushed
the
add-vsock-support-for-macos
branch
from
f6017ee to
7a98262
Compare
Contributor
Author
Sounds good, thanks! |
asomers
approved these changes
Aug 6, 2023
Member
|
There was another CHANGELOG merge conflict, but I fixed that one. bors r+ |
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Contributor
Author
|
Thanks for fixing the changelog conflict! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds vsock support for macOS. It's not possible to create a listening
vsock socket on a macOS host, but you can create one from inside a
VM and connect back to the host.