introduces FreeBSD's SO_TS_CLOCK into net::sys::socket::sockopt.#2093
Merged
asomers merged 3 commits intonix-rust:masterfrom Aug 27, 2023
Merged
introduces FreeBSD's SO_TS_CLOCK into net::sys::socket::sockopt.#2093asomers merged 3 commits intonix-rust:masterfrom
asomers merged 3 commits intonix-rust:masterfrom
Conversation
asomers
reviewed
Aug 26, 2023
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
LGTM, though it needs a rebase to fix a merge conflict in CHANGELOG. Also, you should probably change it to Both instead of SetOnly. It works both ways.
devnexen
force-pushed
the
so_ts_clock_fbsd
branch
from
967cec5 to
8237f37
Compare
Member
|
Guess what? It needs another rebase, both to fix the CHANGELOG and to fix CI. |
devnexen
force-pushed
the
so_ts_clock_fbsd
branch
from
8237f37 to
52ce398
Compare
devnexen
force-pushed
the
so_ts_clock_fbsd
branch
from
52ce398 to
fcb55ae
Compare
asomers
approved these changes
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close GH-2058.