fix: unaligned read panic on macos

[anonkey]

What does this PR do

Checklist:

• I have read CONTRIBUTING.md
• I have written necessary tests and rustdoc comments
• A change log has been added if this PR modifies nix's API

[asomers]

This PR only contains changes to the doc test. Where is the actual code change?

[anonkey]

This PR only contains changes to the doc test. Where is the actual code change?

Wanted to check if misalignment was triggered in CI but wasn't the case so I factorize BSD and Apple test

The separate test case was relevant only locally on my computer

[SteveLauC]

Wanted to check if misalignment was triggered in CI but wasn't the case so I factorize BSD and Apple test

Did you successfully reproduce it in CI? Currently, there is no macOS aarch64 CI in Nix, but since GitHub Action has introduced this, we can enable it if needed.

I am not sure if macOS x86_64 would allow that misaligned read so...

[anonkey]

Wanted to check if misalignment was triggered in CI but wasn't the case so I factorize BSD and Apple test

Did you successfully reproduce it in CI? Currently, there is no macOS aarch64 CI in Nix, but since GitHub Action has introduced this, we can enable it if needed.

I am not sure if macOS x86_64 would allow that misaligned read so...

No i didn't success, maybe because of that, but maybe because memory alignment depends of the OS and lot other random variables, locally it only happens on some groups and i'm not sure if it will be same groups in CI.
I added a apple aarch64 test to check it
I'll disable the fix to check if error happens in aarch64-darwin CI when the runner would be enabled

[anonkey]

don't trigger in CI, i tried 13 groups but none trigger while lot of them crash on my Mac, maybe because of the virtualization of macos?

[SteveLauC]

don't trigger in CI, i tried 13 groups but none trigger while lot of them crash on my Mac, maybe because of the virtualization of macos?

That's possible. BTW, does this patch fix the issue on your host?

[anonkey]

don't trigger in CI, i tried 13 groups but none trigger while lot of them crash on my Mac, maybe because of the virtualization of macos?

That's possible. BTW, does this patch fix the issue on your host?

Definitely, yes
In repro example and in real life product

[SteveLauC]

Thanks!

[aawsome]

Can you say when you are able to release a new version including this fix? We are having users who get this error and would like to use the fix in the dependencies.
Thanks for fixing!

[SteveLauC]

Can you say when you are able to release a new version including this fix? We are having users who get this error and would like to use the fix in the dependencies. Thanks for fixing!

Hi, I think I will release 0.28.0 in the near future (possibly within this week)