recvmsg: Check if CMSG buffer was too small and return an error#2413
Merged
SteveLauC merged 1 commit intonix-rust:masterfrom May 22, 2024
Merged
recvmsg: Check if CMSG buffer was too small and return an error#2413SteveLauC merged 1 commit intonix-rust:masterfrom
SteveLauC merged 1 commit intonix-rust:masterfrom
Conversation
agrover
force-pushed
the
check-ctrunc
branch
6 times, most recently
from
53b4487 to
f92993f
Compare
SteveLauC
requested changes
May 22, 2024
Member
SteveLauC
left a comment
SteveLauC
left a comment
There was a problem hiding this comment.
Hi, thanks for the fix! Generally looks good!
Author
|
Proposed fix accepted and squashed. Took a swag at updating docstring to mention the new error condition. |
If MSG_CTRUNC is set, it is not safe to iterate the cmsgs, since they could have been truncated. Change RecvMsg::cmsgs() to return a Result, and to check for this flag (an API change). Update tests for API change. Add test for too-small buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If MSG_CTRUNC is set, it is not safe to iterate the cmsgs, since they could have been truncated. Change
RecvMsg::cmsgs()to return aResult, and to check for this flag (an API change).Update tests for API change. Add test for too-small buffer.
fixes #2400
Checklist:
CONTRIBUTING.md