Make fields in UnknownCmsg public#2520
Merged
SteveLauC merged 6 commits intonix-rust:masterfrom Oct 19, 2024
hax0r31337:master
Merged
Make fields in UnknownCmsg public#2520SteveLauC merged 6 commits intonix-rust:masterfrom hax0r31337:master
SteveLauC merged 6 commits intonix-rust:masterfrom
hax0r31337:master
Conversation
Member
|
Hi, thanks for the PR!
You mean the socket option? If so, it has already been supported by Nix in #1772, the option type is named Ipv4OrigDstAddr, I think it is more like a BSD style naming:
Linux man page uses |
Contributor
Author
|
I found out shortly after I opened this pull request. |
SteveLauC
reviewed
Oct 18, 2024
Member
Make sense, left a comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Made fields in
nix::sys::socket::UnknownCmsgpublic.This change will allow user to implement custom parsing for unsupported message, such as
SOL_IP, IP_RECVORIGDSTADDR.Checklist:
CONTRIBUTING.md