sys::socket adding GetOnly TCP_FUNCTION_ALIAS for freebsd.#2558
Merged
SteveLauC merged 1 commit intonix-rust:masterfrom Dec 8, 2024
Merged
sys::socket adding GetOnly TCP_FUNCTION_ALIAS for freebsd.#2558SteveLauC merged 1 commit intonix-rust:masterfrom
TCP_FUNCTION_ALIAS for freebsd.#2558SteveLauC merged 1 commit intonix-rust:masterfrom
Conversation
devnexen
force-pushed
the
tcp_function_alias_fbsd
branch
2 times, most recently
from
5c13587 to
de8d410
Compare
SteveLauC
reviewed
Dec 8, 2024
Member
SteveLauC
left a comment
SteveLauC
left a comment
There was a problem hiding this comment.
Can we have a test for this socket option?
Contributor
Author
|
|
to complete `TCP_FUNCTION_BLK` as to get the alias name, if existent, of the TCP stack.
devnexen
force-pushed
the
tcp_function_alias_fbsd
branch
from
3a4bde8 to
5084339
Compare
SteveLauC
approved these changes
Dec 8, 2024
|
|
||
| // We can't know at compile time what options are available. So just test the setter by a | ||
| // no-op set. | ||
| // TODO: test if we can load for example BBR tcp stack kernel module. |
Member
There was a problem hiding this comment.
We just need to ensure the wrapper works, so it is not necessary to do further tests, but having them harms nothing:)
Contributor
Author
There was a problem hiding this comment.
it is more in case future related flag additions, some of which need this alternative stack to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to complete
TCP_FUNCTION_BLKas to get the alias name, if existent, of the TCP stack.