Enable TcpMaxSeg setsockopt option for apple targets#2603
Merged
SteveLauC merged 1 commit intonix-rust:masterfrom Apr 3, 2025
Merged
Enable TcpMaxSeg setsockopt option for apple targets#2603SteveLauC merged 1 commit intonix-rust:masterfrom
setsockopt option for apple targets#2603SteveLauC merged 1 commit intonix-rust:masterfrom
Conversation
71d127f to
8b2c4fa
Compare
SteveLauC
reviewed
Feb 12, 2025
| @@ -0,0 +1 @@ | |||
| Added the TcpMaxSeg socket option for apple targets | |||
Member
There was a problem hiding this comment.
Actually, this socket option was available for macOS, but for getsockopt() only. This PR adds the setsockopt() part
Contributor
Author
There was a problem hiding this comment.
Ah, right you are. Fixed.
Member
|
Could you please give this test an update as well? Lines 161 to 221 in 003bfe4 |
4c4aa25 to
4565854
Compare
setsockopt option for apple targets
Contributor
Author
|
@SteveLauC I updated the test. Had to change it around a bit though since it seems MaxSeg works slightly differently on macos:
Still I hope the test is good enough :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Enables the TcpMaxSeg socket option for apple targets. I've tested this on MacOS, not sure about iOS but I imagine it would work just the same.
Here's some code I used to verify that it works:
Checklist:
CONTRIBUTING.md