Cast the 'addr' argument of 'madvise()' for AIX

[xingxue-ibm]

What does this PR do

The AIX signature of madvise() differs from the POSIX specification, which expects void * as the type of the addr argument, whereas AIX uses caddr_t (i.e., char *). This patch casts addr inside the nix wrapper madvise() to smooth it out.

Checklist:

• I have read CONTRIBUTING.md
• I have written necessary tests and rustdoc comments
• A change log has been added if this PR modifies nix's API

[amy-kwan]

Ping.

Hi @asomers! Would you be the right person to ping in order to review this PR?

[asomers]

This looks ok. But could you please add a changelog entry?

[xingxue-ibm]

This looks ok. But could you please add a changelog entry?

Added file 2655.fixed.md. Thanks for the reminder!

[amy-kwan]

Hi @asomers. I'm not sure if this is an appropriate question to ask, but are there any plans for another release of nix in the future? Just wondering as we're working on AIX support for nix as well, and having this change in a future release would be nice.

[asomers]

@amy-kwan there are usually few obstacles to publishing a new release of Nix. There's been a big one lately, which is a complicated CI breakage, but that should fixed within the hour. So yes, we can publish a new release soon.

[amy-kwan]

there are usually few obstacles to publishing a new release of Nix. There's been a big one lately, which is a complicated CI breakage, but that should fixed within the hour. So yes, we can publish a new release soon.

@asomers Makes sense. Thank you for letting me know!